gharchive.org icon indicating copy to clipboard operation
gharchive.org copied to clipboard

PullRequestReviewEvent is not collected

Open rmohr opened this issue 6 years ago • 6 comments

Hi,

Can very well be that the event is simply not reported from where gharchive takes the events, but I noticed that PullRequestReviewCommentEvents are collected but not PullRequestReviewEvent. As a consequence reviews without extra comments are absolutely invisible in the archive and reviews with comments leave only implicit traces because of the logged comment creation.

Is there a way to improve the situation?

rmohr avatar Oct 10 '18 11:10 rmohr

Paging @annafil for sanity check. Are PullRequestReviewEvent's included in the event stream?

igrigorik avatar Oct 10 '18 17:10 igrigorik

Unfortunately, PullRequestReviewEvent is not available in the event stream right now. I think this is only available as a webhook.

annafil avatar Oct 11 '18 05:10 annafil

@igrigorik @annafil thank you for clarifying this.

I for instance wanted to analyze purely via the archives how many reviews happend on PRs, if they got approved, changes were requested, and so forth. Without seeing hints about reviews in the archives, I think it is necessary to query all PRs and related review. So I think it would be nice to have it.

Does it make sense to let the issue open to track the desire to have it, or is this something which will not be changed?

rmohr avatar Oct 15 '18 08:10 rmohr

Unfortunately this is not something we can fix on our end. This would be a request to the GitHub team to add that data to the API.. /me looks at @annafil :-)

igrigorik avatar Oct 15 '18 22:10 igrigorik

I'll be sure to pass this along :)

annafil avatar Oct 26 '18 15:10 annafil

Any news on this topic, @annafil? 🙂I actually work on an another project of mine, where I would need this kind of event to be sent by the Github API.

kristofdombi avatar Nov 17 '18 08:11 kristofdombi