Roman Mohr comments

Results 249 comments of


                                            Roman Mohr

🐛 Fix controller-tools doesn't support single files as input

/remove-lifecycle rotten

Add auth_patterns support to RPM rule

Rebased and verified on a kubevirt codebase. PTAL.

Add auth_patterns support to RPM rule

Created https://github.com/rmohr/bazeldnf/pull/135 for the two unrelated fixes which I needed to verify it.

Add auth_patterns support to RPM rule

> Created https://github.com/rmohr/bazeldnf/pull/135 for the two unrelated fixes which I needed to verify it. Done

Enforcing Access Control Rules to secure the code base against attacks (Example: two factor authentication enforcement, and/or use of ACL tools.)

We have 2fa as a requirement to be a kubevirt member. I suppose that's sufficient?

Don't write duplicate entries e.g. symlinks to tar file

So, I think we cover files. We fixed that as part of https://github.com/rmohr/bazeldnf/pull/49, seems like we need to do the pass in explicit symlink to the collector right away. #136...

CpioEntry.payload has not been exported

Interesting. I see it at least still here: https://github.com/sassoftware/go-rpmutils/pull/17/commits/5acf7436c00dee9caf9367340b35d8c52961d240 I did not delete anything.

CpioEntry.payload has not been exported

Also the go.mod in this repo is still referencing it and it can build just fine.

CpioEntry.payload has not been exported

For context: @kellyma2 resumed the work of converging back with go-rpmutils in https://github.com/sassoftware/go-rpmutils/pull/36#commits-pushed-eb3c1c2.