Roman Mohr

A few considerations: * Do we need a feature gate? Could we mess up some cgroup considerations done by admins on the node level? Like their slice calculations which they...

> AFAIU any cgroup modifications would apply to the pod cgroup. So any cgroup restriction applied to the pod cgroup > will also apply to the "housekeeping" cgroup (since it...

I just demonstrated how to create a small linter which can run in nogo and would check the file length, because the favoured solution by Dan was a bash script...

@mhenriks can you have a look at this one? Maybe specific to longhorn. @vasiliy-ul thinks that maybe setting some defaults in CDI can help if some defaults are not set...

> If the `--access-mode` flag is not mandatory for `image-upload` command then IMHO it should work without it. This seems to summarize the core of the issue pretty nicely. I...

@aglitke I think that even if we don't want to set a default, we can at least improve on the user-facing side. I would for instance not understand easily what...

/lgtm /approve /hold Feel free to remove the hold when all conversations are done.

I found no good way to add our subresources since they are served on a separate subgroup since CRDs don't support custom subresources. The main issue was that I could...

> With regard to the review, I talked with @FiloSottile on the Gopher Slack about this PR and the next steps are to document the public changes to the API...

> With regard to the review, I talked with @FiloSottile on the Gopher Slack about this PR and the next steps are to document the public changes to the API...