hdmf icon indicating copy to clipboard operation
hdmf copied to clipboard

Fix improperly set new vs overridden attributes

Open rly opened this issue 4 years ago • 1 comments

Motivation

Fix #447 .

Fix bug in BaseStorageSpec.resolve_spec where attributes are not correctly removed from the set of new attributes. __new_attributes contains just the field names but attribute is a field dictionary, so nothing was being removed.

Checklist

  • [x] Did you update CHANGELOG.md with your changes?
  • [x] Have you checked our Contributing document?
  • [x] Have you ensured the PR clearly describes the problem and the solution?
  • [x] Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • [x] Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • [x] Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

rly avatar Nov 02 '20 18:11 rly

The PyNWB test is failing and needs to be investigated.

rly avatar Nov 02 '20 18:11 rly