Craig Ringer

How much benefit is there to PRW2.0 vs using OTLP - is it worth doing?

This proposal would tie in very well with https://github.com/prometheus/prometheus/issues/14984 - where I suggest a way to share reusable query-fragments server-side to make writing queries that join on a lot of...

@GiedriusS I agree, it'd be necessary for all samples to either omit the replica labels, or have replica labels that exactly match those configured on sidecar. Sidecar could check and...

I didn't consider the HA / dedup case; we're too resource-constrained to afford Prometheus + Sidecar HA at the moment. Wouldn't (distributed) Query just execute on both, with the returned...

Thanks @fpetkovski . That's a significant downside, and worth knowing about. It helps explain why the Thanos design is so reliant on Series gRPC not pushdown. Distributed Query must fall...

Consider adding to PR description that This relates to prior work on re-sorting responses with external labels in https://github.com/thanos-io/thanos/issues/8487, and memory-use increases as discussed in https://github.com/thanos-io/thanos/issues/7395 . This change only...

> The key issue is that dropping an internal label can cause the set to become unsorted, I don't think where we store external labels changes this. This is only...

@MichaHoffmann suggested naming changes > maybe "tools_grpc.go" with "thanos tools grpc query-range" and such which I can adopt soon. We discussed the formatting code too. I explained that the json...

I have hesitations about adopting something that makes streaming large result sets even harder, personally. This is often desirable for intermediate results in distributed Query etc. I'd also be worried...

Since Prom can now `label_replace` on a wider variety of vector types and queries, this is more easily worked around than in the past. Many cases can be handled with...