Craig Ringer

RBAC is one consideration here. If Prometheus only has permission to see the targets it should be scraping, but tries to enumerate all of them then drop them via label...

So the metrics are renamed, but the documentation doesn't mention the new ones? And the old ones are still exported, mentioned as deprecated, but may carry stale and incorrect values?

I don't immediately see support for this in `pgx`, but no support existed in the prior dedicated driver that was used either.

Looks like `sql_exporter` has a variant of this in https://github.com/burningalchemist/sql_exporter/pull/433 (https://github.com/burningalchemist/sql_exporter/issues/178) with the `jobs[]` parameter. Query params are accessible as e.g. `req.URL.Query()["jobs[]"]` on the request object passed from promhttp, so...

Thanks. I aim to do just that.

Looks like managing multiple registries is the preferred way to handle grouping: https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#Registry . It can also be used for things like parallel scrape from multiple goroutines, if required. To...

Raised https://github.com/prometheus/client_golang/issues/1538 with prom client. If prom propagated `context.Context` from the `http.Request` through to `Collect(...)` it'd all be so much cleaner and easier. As it is, it looks like a...

I haven't forgotten this, and will try to clean up and upstream my patch when I get the chance. Just under the pump for some internal work.

Thanks. As it stands my working branch is way too dirty to merge. I'll try to get back to cleaning it up and finishing it off.

Sorry about that! Yes, thanks for reverting. I can look into it later and see. I can work around the issues I have with `lib/pq` for now or carry a...