Craig Ringer
Craig Ringer
After rebasing on top of the win32 fixes I see this failure when running this branch's `make test-wine` ``` ➜ spiffe-helper git:(test-suite-for-cmd-and-signal-file) ✗ wineme make test-wine GOOS=windows go test -exec...
I pushed a fix for the failure on rebase. The `TestSignalProcess` test didn't work on Windows/wine.
@faisal-memon I've rebased this and fixed the DCO. Tests run on linux/amd64 and win32/amd64(wine). ``` ➜ spiffe-helper git:(test-suite-for-cmd-and-signal-file) ✗ make test go test ./... ? github.com/spiffe/spiffe-helper/cmd/spiffe-helper [no test files] ?...
@faisal-memon I think I've addressed your review comments. Thanks, that helped catch a mistake in my logic for test stdio handling.
> @ringerc I see this when running the tests. Is it expected? > > ``` > === RUN TestSidecar_RunDaemon > === RUN TestSidecar_RunDaemon/svid_with_intermediate > util_test.go:115: WARNING: sidecar process 34971 still...
The PR that proposes to fix this is: * https://github.com/spiffe/spiffe-helper/pull/252 but it depends on a series of other PRs that need merging first so it can be rebased onto them:...
I raised this in #8866 after missing this issue in a search (somehow). As I noted in that issue, it'd also be extremely helpful if the connector error mentioned the...
People use it in production. It's open source and there's no specific support policy as far as I know. So I guess that's up for you to judge. You can...
``` ➜ kube-state-metrics git:(f9f0a178) ✗ git bisect start v2.17.0 v2.16.0 HEAD is now at f9f0a178 Merge pull request #2757 from Rishab87/prep-v2.17.0 Bisecting: 32 revisions left to test after this (roughly...
``` ➜ kube-state-metrics git:(f9f0a178) ✗ dlv debug main.go -- --config=config.yaml --kubeconfig=$KUBECONFIG (dlv) break ./internal/wrapper.go:83 Breakpoint 3 set at 0x2c73812 for k8s.io/kube-state-metrics/v2/internal.RunKubeStateMetricsWrapper() ./internal/wrapper.go:83 (dlv) r Process restarted with PID 637192 >...