Craig Ringer
Craig Ringer
I worked around this by only using `*` for all my label enrichment. It's unfortunate but tolerably effective.
Added some test cover for command exec. Will add some for pid signalling next.
I see some linter complaints here. I'll address them, and probably split the PR.
Windows fixes split off to simpler individual PR: https://github.com/spiffe/spiffe-helper/pull/257 Added test cover split off to a PR that focuses on adding the test cover, https://github.com/spiffe/spiffe-helper/pull/258 I've rebased this PR onto...
I won't bother rebasing this since the merge conflict is actually in one of the dependent commits that I've already fixed over in https://github.com/spiffe/spiffe-helper/pull/258 . When that gets merged, I...
@faisal-memon I've run out of time and capacity to update for the conflicts at this point. I'll try to return to if it I can.
This requires a rebase now. It would've been great to merge these before making changes to the code these tests exercise, so the new changes could be covered by the...
Fixed test compilation and execution. It seems to now run serialized for each sub-test though. Presumably an issue with the added mutex, or with my merge. Will look into it....
Whew. That took a surprising amount of doing but I think the tests are better for it. Note that these tests do not attempt to "shut down" the sidecar completely...
Thanks @faisal-memon