Craig Ringer
Craig Ringer
Comparing to 2.16.0 ``` ➜ kube-state-metrics git:(291a9628) ✗ dlv debug main.go -- --config=config.yaml --kubeconfig=$KUBECONFIG ➜ kube-state-metrics git:(291a9628) ✗ dlv debug main.go -- --config=config.yaml --kubeconfig=/home/craig/projects/EDB/UPM/upm-stack/appliance-access/kind-beaconator/.kubeconfig Type 'help' for list of commands....
Found the cause. https://github.com/kubernetes/kube-state-metrics/pull/2703/files#r2475892642 The option was renamed from `custom_resource_config_file` to `custom_resource_state_config_file`.
@mrueg Given that it was never formally documented I don't think it's strictly a regression. I might see about raising one to document it at least. If you want it...
Does this also result in crashes in Thanos Query in Distributed mode? I've not seen any. If not, I wonder what's different about how this test workload uses the API....
None of these test failures look related to the PR to me.
Thanks @keithmattix for checking and for the review. I don't have permission to merge.
Rebasing and running "make gen". Will see.
@zirain & @keithmattix Rebased. `make gen` didn't change any files - which makes sense. Surprisingly doesn't require a new approval after rebase.
This probably needs backporting to 1.28.x