Results 84 comments of Erik Rigtorp

> Not necessarily, on my own page the 404 error page has `404` and the path is left intact, which [allows me to filter by it](https://stats.arp242.net/?filter=404) quite nicely. This would...

You could add to the docs that a 404 page needs to have 404 in the title. But yeah that's why I was saying that you need a specific ``...

@tmontgomery Does this project require C++11 or higher? Because that is needed for enum classes. If we do require C++11 or higher we could remove the `SBE_NOEXCEPT` and `SBE_CONSTEXPR` macro.

Sure, that's why it's better to target some common platforms (Ubuntu LTS, Centos, SUSE, whatever is common non-EOL VS) and run CI against them. I'm pretty sure all of them...

I would be happy if only current master with the fix to support sklearn 1.0 #1063 would be released.

> 1. The line: > `char padding_[kCacheLineSize - sizeof(writeIdxCache_)]` > has no effect as the global structure has a size that is already quantized, because of `alignas(kCacheLineSize)` members. It's required...

> Compilers automatically insert padding at the end of a struct, to ensure that arrays of the struct will be properly aligned. This does not depend on the C++ version....

That's a bug in LLVM. Just comment out that code until your compiler is fixed

Yes I think the empty key should be selected through a template parameter instead of a constructor argument at runtime.

Right, it would make sense to either start with not allocating the item storage and/or to start with a minimum of 8 or something reasonable.