Erik Rigtorp comments

Results 92 comments of


                                            Erik Rigtorp

Assertion failed

Yes, those first two are invalid and will break the queue invariants. I really should never have used the front() and pop() APi from std::queue. Instead they should be a...

Benchmarking against other queues ?

Yes but I don't have time!

Mark as system includes unless building standalone

I think I would rather fix the warnings. What warnings did you encounter?

Mark as system includes unless building standalone

Catch2 also doesn't mark the includes as SYSTEM: https://github.com/catchorg/Catch2/blob/devel/src/CMakeLists.txt#L395 If you use ExternalProject you can patch there. If you vendor you can just modify the CMakeLists.txt.

Add option to TVDB plugin to use the DVD data

I'm proposing to add an option to the plugin to use the DVD info by default.

This does work on ARM?

There's actually a paper from Hans Boehm showing that you cannot express Seqlock in C++11 memory model :(. I would recommend making your own version that uses assembly to insert...

This does work on ARM?

Yes and unfortunately it's not really possible to implement seqlock in C++11 :( On Thu, Mar 2, 2023 at 12:52 AM stravager ***@***.***> wrote: > axelriet the whole point of...

Modify some array index operations

I agree, ideally this should be configurable using a template parameter.

Fixed uninitialized output.

Thanks for the PR. I'm not sure how this could happen? Why are the number of samples for cpu 6-11 0? I would rather fix that underlying issue than the...

Fixed uninitialized output.

Fixed here https://github.com/rigtorp/hiccups/commit/071656c016a361620db12ff28b22f6d9f18856d8