Erik Rigtorp

You can view the build results here: https://github.com/rigtorp/date/actions

@HowardHinnant Need a review on this. It has several fixes for Windows support.

Compiled with `/std:c++14 /Zc:__cplusplus` so `__cplusplus` shoud be `201402L`: (https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/) ``` 2020-04-14T20:45:59.9476192Z D:\a\date\date\test\date_test\durations_output.pass.cpp(316,62): error C2248: 'date::detail::string_literal::string_literal': cannot access private member declared in class 'date::detail::string_literal' [D:\a\date\date\build\date_test_pass_durations_output_bin.vcxproj] 2020-04-14T20:45:59.9485090Z D:\a\date\date\include\date\date.h(4018): message : see...

See https://github.com/HowardHinnant/date/pull/572/commits/1f51c9d96abf5e7758409bfbc5b4cdbd27f8abef

Looks like it's broken for both `199711L` and `201402L`.

> ...or we could move the public header files. Libssh 0.9.4, for example, has "include" and "src" directories under the top-level directory. We could put the public header files in...

Yeah I do pcap_dump_flush before closing, but there's no way to get the return value from fclose. I'll open a MR to make these minimal changes. Any new API should...

I don't agree, the action/verb is the same. You wouldn't add _with_error on every function that returns an error of it wasn't to fix a API issue. I marked pcap_dump_close...

What's the conclusion on the naming of these new functions? I would like to move forward and discuss the implementation changes and hopefully get this merged. On Thu, Aug 26,...

@guyharris @infrastation any updates regarding the naming?