scikit-optimize icon indicating copy to clipboard operation
scikit-optimize copied to clipboard

[Request] Make new releases compatible with modern scikit-learn

Open QuentinSoubeyran opened this issue 4 years ago • 7 comments

Making a 0.9 release, compatible with scikit-learn>=0.24, and one with the new features would be nice.

0.9.0 release (Already released) (bugfixes, compatibility with scikit-learn>=0.24):

  • [X] Merge #988 (fix many issues of scikit-learn 0.24 compat)
  • [x] Merge #1063
  • [X] Merge #1069
  • [x] #1075

Unmerged PR:

  • [ ] #971
  • [ ] #1012
  • [ ] #1050
  • [ ] #1055
  • [ ] #1062
  • [ ] #1066 (fix #1056 )
  • [ ] #1067 (fix #1065)

Unofficial test branch I have made an unofficial test branch on my fork, unofficial, for testing some of those features. If someone wishes to test features & fixes, one can install from source using

pip install git+https://github.com/QuentinSoubeyran/scikit-optimize.git@unofficial

Warning: If you are using this unofficial branch, before reporting an issue:

  • If the issue is reproducible with the master branch from this repo, open an issue in this repo
  • If not, identify which PR causes the issue, and add a comment in the discussion for this PR

See also: #1059

EDIT: edited plan to reflect @xmatthias comment EDIT: edited to reflect release of 0.9.0 version EDIT: update test branch, formatting

QuentinSoubeyran avatar Oct 01 '21 15:10 QuentinSoubeyran

I would be happy if only current master with the fix to support sklearn 1.0 #1063 would be released.

rigtorp avatar Oct 04 '21 18:10 rigtorp

I think there should be a interim 0.8.2 release with current master (call it compatibility release?)

From a projects perspective, it's pretty risky to merge a ton of PR's right before a Release - people testing specific PR's or branches (like requested above) will often not have the edge-cases other users encounter. So i fear that this approach will delay a release for weeks/months, or worse, result in an unstable 0.9.0 release, as some obtruse compatibility-issues between the PR's might appear.

While current master would be pretty stable as far as i can see (the above PR's don't seem to fix anything that wasn't present in 0.8.1 as well).

xmatthias avatar Oct 05 '21 05:10 xmatthias

@kernc with the release of 0.9.0, feel free to close this. I can also update it to serve as information for people coming on the repo. Though an official, pinned issue would probably be better for that.

QuentinSoubeyran avatar Oct 17 '21 15:10 QuentinSoubeyran

@RNarayan73 you should use the above unofficial branch instead of the old mock branch if you want to test un-merged features.

QuentinSoubeyran avatar Oct 19 '21 10:10 QuentinSoubeyran

I tested the multimetric feature in the unofficial branch and it works fine. Thanks, Narayan

RNarayan73 avatar Oct 23 '21 15:10 RNarayan73

Thanks! the multi-metric is working for me as well on this branch! hope this can be merge in the future to the main branch

jmnunezd avatar Apr 27 '23 15:04 jmnunezd

I'm afraid the library hasn't been updated for other a year, so this is unlikely. The last 0.9.0 release is quite dated, and there hasn't been any activity from the maintainers since.

QuentinSoubeyran avatar Apr 28 '23 10:04 QuentinSoubeyran