Erik Rigtorp

Add build workflow using GitHub Actions

2

- Cleans up CMake code for fail tests to work on Windows - Add Windows build using GitHub Actions which is not flaky unlike Travis - Since date requires C++14...

Use feature test macros instead of __cplusplus version for feature detection

8

This code can be updated to use ` __cpp_lib_uncaught_exceptions ` and ` __cpp_lib_void_t` feature test macros: ``` #ifndef HAS_UNCAUGHT_EXCEPTIONS # if __cplusplus > 201703 || (defined(_MSVC_LANG) && _MSVC_LANG > 201703L)...

Test zoned_time_deduction.pass.cpp fails to build on MSVC 2019

1

Compiler flags: `/std:c++17 /Zc:__cplusplus` ``` 2020-04-14T21:06:53.5961785Z Building Custom Rule D:/a/date/date/CMakeLists.txt 2020-04-14T21:06:53.6922654Z validate.cpp 2020-04-14T21:06:54.5988592Z D:\a\date\date\include\date\date.h(1066,23): warning C4996: 'std::uncaught_exception': warning STL4006: std::uncaught_exception() is deprecated in C++17. It is superseded by std::uncaught_exceptions(), plural....

durations_output.pass.cpp test fails to build on VS 2019

4

Compiled with `/std:c++14` so `__cplusplus` shoud be `199711L`: ``` 2020-04-14T19:28:58.6121126Z Building Custom Rule D:/a/date/date/CMakeLists.txt 2020-04-14T19:28:58.7016300Z durations_output.pass.cpp 2020-04-14T19:28:59.3537570Z D:\a\date\date\test\date_test\durations_output.pass.cpp(316,26): error C2127: 'integer': illegal initialization of 'constexpr' entity with a non-constant expression...

Compile flags: `/std:c++14 /Zc:__cplusplus` ``` 2020-04-14T20:47:05.0527030Z Building Custom Rule D:/a/date/date/CMakeLists.txt 2020-04-14T20:47:05.1503480Z year.pass.cpp 2020-04-14T20:47:05.5805724Z D:\a\date\date\test\date_test\year.pass.cpp(116,9): error C2338: [D:\a\date\date\build\date_test_pass_year_bin.vcxproj] 2020-04-14T20:47:05.5971571Z D:\a\date\date\test\date_test\year.pass.cpp(130,9): error C2338: [D:\a\date\date\build\date_test_pass_year_bin.vcxproj] ``` https://pipelines.actions.githubusercontent.com/SHby2MV2A4DY7MZ0pDxE44EksVhZVkG27wazOBcqS8b0B5WGLo/_apis/pipelines/1/runs/24/signedlogcontent/13?urlExpires=2020-04-14T20%3A55%3A42.8531808Z&urlSigningMethod=HMACV1&urlSignature=28rNlJII1cRJSi7AHWwLei2wptczLTMgWXmVdogWOeo%3D

First I want to thank you for creating this great tool. It has helped me work with bigger than main memory datasets that Pandas could not handle. I like to...

Return errors from pcap_dump and pcap_dump_close

11

- [X] Add new functions pcap_dump1, pcap_dump_close1 that returns PCAP_ERROR on error - [X] Update manpages - [X] Update CMakeLists.txt to install symlinks for new manpages - [X] Update Makefile.in...

pcap_dump should return -1 on fwrite error

3

Currently it's cumbersome to detect if there was an error when writing to a dump file. You need to use `pcap_dump_fopen(stream)` and then check `ferror(stream)` after each call to `pcap_dump`....

Allow -w to take paths containing date/time components when using -G

9

When using the -G option it can be useful to organize files by year/month/day by setting `-w %Y/%m/%d/%Y%%m%dT%H%M%SZ.pcap`. This will fail if any of the parent directories are missing. We...

In particular when doing long term captures and using the -G option it's useful to compress on the fly. It's already possible to compress files using the post-rotate command, but...