RickyMa comments

Results 168 comments of


                                            RickyMa

[#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients

@zuston @jerqi PTAL.

[#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients

This should be merged too. It might affect some old spark versions which do not have commons-collections4 dependencies. @jerqi @zuston

[#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients

ping @zuston @jerqi ~~

[#1743] fix: Add exception handling for thread pools

@zuston @jerqi PTAL.

[#1743] fix: Add exception handling for thread pools

At least from the tests I've conducted, no exceptions have been thrown out.

Fix: Improve shuffle unregister timeouts

This PR is more reasonable. But I'm worried about the new total timeout seconds being too large, which will cause the driver too long to stop, will it?

Fix: Improve shuffle unregister timeouts

> only if individual requests take very long or timeout... Yeah, should we add an upper total timeout for this situation? e.g. the total timeout

Fix: Improve shuffle unregister timeouts

> So I am not sure why we are seeing those interrupt exceptions. Either these indicate timeouts or some other cause interrupt. Also, the reasons are still unclear. We need...

Fix: Improve shuffle unregister timeouts

There are still conflicts left to be resolved.

Fix: Improve shuffle unregister timeouts

Any progress? ping ~ @EnricoMi @zuston