incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#1743] fix: Add exception handling for thread pools

Open rickyma opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Add exception handling for thread pools.

Why are the changes needed?

Fix: https://github.com/apache/incubator-uniffle/issues/1743.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

rickyma avatar May 28 '24 05:05 rickyma

Test Results

 2 394 files   - 25   2 394 suites   - 25   4h 45m 14s :stopwatch: - 13m 28s    933 tests ± 0     932 :white_check_mark: ± 0   1 :zzz: ±0  0 :x: ±0  10 731 runs   - 88  10 718 :white_check_mark:  - 87  13 :zzz:  - 1  0 :x: ±0 

Results for commit 69fd0724. ± Comparison against base commit 59e50908.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
org.apache.uniffle.test.CoordinatorAssignmentTest ‑ testReconfigureNodeMax
org.apache.uniffle.test.CoordinatorReconfigureNodeMaxTest ‑ testReconfigureNodeMax

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 28 '24 06:05 github-actions[bot]

@zuston @jerqi PTAL.

rickyma avatar May 28 '24 06:05 rickyma

At least from the tests I've conducted, no exceptions have been thrown out.

rickyma avatar May 29 '24 03:05 rickyma