RickyMa comments

Results 168 comments of


                                            RickyMa

[Improvement] Unit tests support mocking the ShuffleServerNettyHandler class

This is really important in Netty mode. Anyone is welcome to pick this up.

[Improvement] Unit tests support mocking the ShuffleServerNettyHandler class

> This is really important in Netty mode. Anyone is welcome to pick this up. When running in prod, we currently use Netty mode due to https://github.com/apache/incubator-uniffle/issues/1651, so this issue...

[Bug] A more elegant way to delete files is needed

When cleaning expired resources, no matter it is an HDFS file or a normal disk file, we always do the following things in `HybridStorageManager.removeResources`, that's why en exception is thrown:...

[Bug] A more elegant way to delete files is needed

Yeah, it's better this way, so we can reduce a lot of meaningless warn logs.

[Bug] ConcurrentModificationException is thrown when calling Roaring64NavigableMap.getLongCardinality

> I suggest to use lock or clone to avoid race condition Seems fine. > we can use try catch to ignore this kind exception for testing I think this...

[Bug] ConcurrentModificationException is thrown when calling Roaring64NavigableMap.getLongCardinality

You can refactor the test cases, or maybe just disable the tests.

[FEATURE] A more thorough data cleaning mechanism

@zuston @dingshun3016 @yl09099 @xianjingfeng Have you ever encountered this issue in prod?

[Improvement] Enhance Netty test coverage

Sure. Please go ahead.

[MINOR] fix(dashboard): Fix NPE while without targetAddress for api/server/nodes

@xianjingfeng PTAL

[MINOR] fix(dashboard): Fix NPE while without targetAddress for api/server/nodes

Merged to master. Thanks @maobaolong @xianjingfeng