incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#1699][FOLLOWUP] fix(client): Add commons-collections4 dependencies in shaded clients

Open rickyma opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Add commons-collections4 dependencies in shaded clients.

Why are the changes needed?

After https://github.com/apache/incubator-uniffle/pull/1700, in some versions of Spark, the commons-collections4 dependency could be missing. Add the potential missing dependency to improve robustness.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs. Tested in our env.

rickyma avatar May 28 '24 05:05 rickyma

Test Results

 2 419 files  ±0   2 419 suites  ±0   4h 58m 23s :stopwatch: -17s    933 tests ±0     932 :white_check_mark: ±0   1 :zzz: ±0  0 :x: ±0  10 819 runs  ±0  10 805 :white_check_mark: ±0  14 :zzz: ±0  0 :x: ±0 

Results for commit 2afef5df. ± Comparison against base commit 59b899eb.

github-actions[bot] avatar May 28 '24 05:05 github-actions[bot]

@zuston @jerqi PTAL.

rickyma avatar May 28 '24 06:05 rickyma

This should be merged too. It might affect some old spark versions which do not have commons-collections4 dependencies.

@jerqi @zuston

rickyma avatar May 30 '24 06:05 rickyma

ping @zuston @jerqi ~~

rickyma avatar Jun 03 '24 03:06 rickyma