RickyMa comments

Results 168 comments of


                                            RickyMa

Server crashes when a player connects (Segmentation fault (core dumped))

Ran into this too. I have to keep using the old versions for now.

[#1628] fix: Retain netty byteBuf when decoding

When `decodeBody` is true, we don't release the `ByteBuf` during decoding. We will release it later in our business codes.

[#1628] fix: Retain netty byteBuf when decoding

Yes, at least from what I see in the code right now, this should be the logic. So `retain` is not necessary.

[#1628] fix: Retain netty byteBuf when decoding

If I get this correctly: before decoding --> `refCnt` is `1` after decoding --> `refCnt` is `1` (keep still) business codes call `release()` --> `refCnt` is `0` If you call...

[#1628] fix: Retain netty byteBuf when decoding

> Does the Netty framework will release the ByteBuf after processing the request? This problem happens occasionally, not every time. If the Netty framework will release the ByteBuf after processing...

[Improvement] ShuffleBlockInfo.getSize can be optimized when enabling Netty using off-heap memory

It's been a long time. I don't know if the code has already been optimized by @maobaolong in some other way.

[#1651] improvement(netty): Set Netty as the default server type

OK, I'll keep this PR here. When it is ready, anyone can modify on top of this PR.

[#1651] improvement(netty): Set Netty as the default server type

@maobaolong I think you can continue working on this PR.

[#1651] improvement(netty): Set Netty as the default server type

> MR/TEZ don't support Netty now. I hesitate to make it default. @jerqi I think maybe we can merge this now? I've fixed the conflicts btw.

[#1651] improvement(netty): Set Netty as the default server type

Merged. Thanks for your reviews @jerqi @zhengchenyu @zuston