Mount leak in platform_supports_deferred_deletion()

[edsantiago]

Line 141:

mount -o bind $TEMPDIR $TEMPDIR

...but lines 143 & 148 return without umounting. System is then left with stuck mounts:

/dev/vda1 on /tmp/tmp.vBynTZ78If type xfs (rw,relatime,seclabel,attr2,inode64,noquota)

[rhvgoyal]

Ed, in your case which line is returning without mounting? 143 or 148?

[edsantiago]

It's actually 143, because of what I can only assume is a packaging bug: /usr/lib/docker{,-latest}-storage-setup/dss-child-read-write does not seem to exist. I'm 99% sure, once I get to 100% I'll file a bz

[rhvgoyal]

cc @lsm5

[edsantiago]

Regardless of which return is at fault, both should be fixed (add umount before each one)

[rhvgoyal]

yep, I am fixing that now