Javier Rengel Jiménez

Results 89 comments of Javier Rengel Jiménez

no, that's ok for now, as long as we don't get weird like bugs like 0.49999999 in queries when using floats :sweat_smile:

@joaoviana this is a bit hard to test, so feel free to skip some of the testing. Or use some repo on Lightdash to test part of the flow.

Comments from @TuringLovesDeathMetal - this is only available for users who are developers or above for a given project, correct? - ^do developers have access to the project management page...

> Just to confirm, this is so that >= developers can write back, right? because org editors can't - mentioning this because of the main ticket Yes, you need to...

This is breaking some of the charts I had on analiytics https://analytics.lightdash.cloud/projects/21eef0b9-5bae-40f3-851e-9554588e71a6/sql-runner/feature-usage-total-users-using-custom-tooltips/edit

> According to https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#installation the application receives this webhook when the installation is completed. So after approval, it should receive a call with action=created. > Can't you keep the application...

This is the most reasonable approach https://github.com/orgs/community/discussions/42351#discussioncomment-10100103 We could do some polling to `OctokitRest().apps.listInstallationsForAuthenticatedUser` and wait for the app to be authorized (it should appear on the list of accessible...

Unable to reproduce after the recent refactoring

Check this chart https://analytics.lightdash.cloud/projects/21eef0b9-5bae-40f3-851e-9554588e71a6/sql-runner/what-dbt-versions-are-being-used-in-the-last-6-months 30% is still using 1.4 and 25% 1.8 Almost everyone using Github actions might be using 1.4, since that version ins pinned in the github YML.

CLI tests are also failing for 1.9, why ?