Javier Rengel Jiménez

Results 89 comments of Javier Rengel Jiménez

@owlas we need admin permissions on github to do this . not urgent

We can do the same thing for these 2 https://github.com/lightdash/cli-actions/pull/1 (probably need to create a separate repo)

Ok, this seems to be a simple way of doing server-side rendering, without adding too much code or dependencies to lightdash ## Add new chrome headless docker container ``` browser:...

I've never used `read-dom/server`. Does not `react-dom/server` require a big refactoring to work ? at least sharing the components between the backend and frontend, and maybe changing the way they...

@ZeRego let's unblock this. Should we then start building this without react-dom/server until this blocker is fixed ?. I think it should be easy to migrate. So we can be...

I'm looking into this, it sounds like a big task.I'll see what I can do

I got 1 implentation question. Should this be a new `ChartType` ? (like Table or BigNumber) or be type of `Cartesian` chart (CartesianSeriesType) ...

I can spend some time to figure out how difficult this is. But if you have something else more urgent, let me know.

Yeah, I made a draft a while ago but we deprioritized this, not sure how relevant this is anymore @TuringLovesDeathMetal

Pressing `ESC` does not just close the dropdonw, but it closes the whole popup. This could be a solution if we're able to capture the key [Screencast from 10-10-22 15:32:27.webm](https://user-images.githubusercontent.com/1983672/194878276-f49baca1-0ee1-4a71-9a41-a887fdebad46.webm)