lightdash feat: custom dimensions custom range float values

feat: custom dimensions custom range float values

Open IrakliJani opened this issue 1 year ago • 3 comments

Closes: https://github.com/lightdash/lightdash/issues/11859

Description:

mantine 7 offers the option to have floats in the number input. but mantine 6 does not. changed to text input instead of number input and I also added a zod schema

Reviewer actions

[ ] I have manually tested the changes in the preview environment
[ ] I have reviewed the code
[ ] I understand that "request changes" will block this PR from merging

Oct 17 '24 16:10 IrakliJani

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name	Link
Latest commit	58fb8fef34738fe745b286ee65570b216e5d41d9
Latest deploy log	https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/6716508b2a5cef000867d5b7

Oct 17 '24 16:10 netlify[bot]

@rephus really good point! let me check that

Oct 21 '24 10:10 IrakliJani

@rephus fixed that. included a comment in the code

Oct 21 '24 11:10 IrakliJani

@rephus Technically, they can be strings. We don't perform any calculations with them, as far as I remember... But it’s usually not an issue unless someone has an issue with it 😁

Let me know if it's worth changing!

Oct 21 '24 13:10 IrakliJani

Releasing this as is. @rephus, let me know if I should create a ticket and change it to a string. Although, if we do that, it would mean that we have both (number and string) saved in the DB.

Oct 21 '24 14:10 IrakliJani

:tada: This PR is included in version 0.1310.0 :tada:

The release is available on: