Javier Rengel Jiménez

Results 89 comments of Javier Rengel Jiménez

Waiting for tests to run. I tested manually and it seems good

Relevant code is here https://github.com/lightdash/lightdash/blob/main/packages/frontend/src/hooks/echarts/useEchartsCartesianConfig.ts#L1485

For context, we don't calculate totals on pivot tables for metric type `number`, because the `sum` of numbers is not a correct total. Let's take this example: I have a...

There are 2 ways IMO to get into this state. by creating triggering `start-preview`(with different names) , or using `preview` and killing with CRTL-C before deletion. > One idea: when...

> We can use cron jobs or similar to destroy preview projects after 1 day of being created. And have an option in the CLI command to adjust that time....

I still need to test the memory usage on large files :eyes:

Memory load testing (100k random results) This generates a 38mb jsonl file ## Saving files ### With streaming (not blocking API) ![image](https://github.com/lightdash/lightdash/assets/1983672/2034e5e8-0083-4b60-b404-73609c2c3bde) ![image](https://github.com/lightdash/lightdash/assets/1983672/72ee25a1-0aca-4485-9cc8-cf4ff0e0745f) ``` const fileId = await this.streamResultsToLocalFile(async (writter)...

Memory load testing (50k rows) ## Streaming results ### With read buffer pipe ![Screenshot from 2024-07-03 10-20-02](https://github.com/lightdash/lightdash/assets/1983672/720fdee8-cfeb-4337-a406-50db19a3d598) After downloading file ![Screenshot from 2024-07-03 10-20-11](https://github.com/lightdash/lightdash/assets/1983672/05500374-7393-4c45-8681-2af6cd60b085) ``` if (res) { readStream.pipe(res); await...

* **#15354** : 5 dependent PRs ([#15391](https://github.com/lightdash/lightdash/pull/15391) , [#15398](https://github.com/lightdash/lightdash/pull/15398) , [#15418](https://github.com/lightdash/lightdash/pull/15418) and 2 others) 👈 (View in Graphite) * `main` This stack of pull requests is managed by Graphite. Learn...

Unrelated error ? ![image](https://github.com/user-attachments/assets/fe37521a-a756-44db-989f-2bbd799d6f0c)