Javier Rengel Jiménez
Javier Rengel Jiménez
Build failed 18.14 Type 'Promise' is not assignable to type 'Promise'. 18.14 Type 'string' is not assignable to type 'null'. 18.14 src/features/comments/components/DashboardTileComments.tsx(89,25): error TS2322: Type '(text: string, textHtml: string, mentions:...
Easy fix, but we'll need to make sure we can add this `unique` filter on prod before merging, otherwise migration will fail. Specially on app and eu1
@PriPatel do you have any feedback about this ? I was planning to add an :link: icon next to the `gsheet` file that opens on a new tab
This emulator indeed support multiple ROMs from NES, but you might want to look at the original source of JSNES here: https://github.com/bfirsh/jsnes . I decided not to include any more...
You can load roms in any way you want. You can upload the roms along with the source, or have them on a separate URL (eg: S3) or even request...
I'm focusing on other things right now, but feel free to submit a PR :)
Hi @Shifan-Gu there are a few errors with types, could you take a look ? I'll review the code and test it in the meantime 
Sorry, this is taking longer to review because of this change https://github.com/lightdash/lightdash/pull/10082/commits/0d72b169ecdcce95c89c4727afa06783bbfbd69e I need to test everything again. Next time I'd rather do these non-blocking changes on a separate PR...
The issue I mentioned hasn't been fixed. I don't get any warnings if the permission is not correct.   But let's not fix this here, let's...
Another weird UI behaviour, probably caused by the recent change in permissions. I can upgrade permissions for indivdiual users in the group, but I can downgrade. eg: if The group...