Erik Marks

Results 52 comments of Erik Marks

The module namespace object now also has a `@@toStringTag`. See #1972.

Jean-Marc, I work with David and have been working with a fork of your repo. I have a couple of questions concerning your to-do's: 1. You already implemented typed state...

Great, you're very helpful, thanks a lot!

I believe this is another instance of the same problem (originally reported in #2074): ### Steps to reproduce ``` > endo make counter.js --name counter > endo eval 'E(counter).incr()' counter...

We believed that this was fixed by #2092. Rather than fixing the bug, however, that PR concealed it by always creating a new incarnation of `eval` formula workers, even if...

@SilentCicero will merging this fix impact Fuel's usage of `eth_signTypedData_v4`?

We should probably consider doing this sometime, although we'd likely have to scrape the data given our usage (see bottom of page [here](https://4byte.directory)). GitHub project page: https://github.com/pipermerriam/ethereum-function-signature-registry

I'm considering how we can return the full, native `Error` object to the caller via the `Promise`-based `engine.handle` signatures. We can't cause `engine.handle` to reject because we need to pass...

> the callback api and async api are different and shouldnt be mixed @kumavis this is working up to resolving that problem. In #83 (dependency: #81 (this) -> #82 ->...

The main reason for removing `next` is that the async middleware pattern of `await next(); /* do stuff */; return;` invariably violates the [`node/callback-return`](https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/callback-return.md) ESLint rule. I agree with the...