Erik Marks

~Converting to draft while figuring out how best to fix `wallet_invokeSnap` (i.e. the sugar for `wallet_snap`), whose implementation assumes that it runs before the permission middleware.~ ~_Update:_ We will need...

> Can the typescript conversion be split out in a separate PR, preceding the rest of the changes in this one? @legobeat I don't think a separate PR is worth...

@legobeat added context to description: > This is merely an expedient to unblock https://github.com/MetaMask/metamask-extension/pull/24550. The underlying issue will be addressed in the relevant packages.

@legobeat no!

I think this comment got dismissed due to a rebase, so restating it (re: `app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.test.js`): > Are there any test cases for when the chain permissions feature flag is enabled?

@legobeat there's definitely unmigrated JS code, but also the types for the method middleware and its handler + hooks pattern are currently broken and implemented in 3 different repositories. 🙃We're...

@kriskowal, I believe we originally planned to derive child segment formula numbers from their parents, but #2089 removed derivation in favor of randomly generating all formula numbers. Can we reintroduce...

This issue previously referenced a second case, which "may or may not be distinct". As it turns out, it is both distinct and known, and is now tracked in #2021.

We observe datalocks about half the time during crossed hellos in #2217, likely on the side that has to drop their existing connection and therefore cancel all dependent formulas. We...

There are pet name path utilities in `cli/src/pet-name.js` and `daemon/src/pet-name.js` that look like they could be used in a variety of places in this PR.