Erik Marks

Results 52 comments of Erik Marks

I have reproduced the freezing locally in Chrome on `develop` while importing a wallet file created by `geth account new`. We are investigating the cause and will report back once...

Here are my findings from reproducing this issue. When importing an account from a JSON file, we end up making [this call](https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/account-import-strategies/index.js/#L40) to `ethereumjs-wallet`. The extension freezes on [this line](https://github.com/ethereumjs/ethereumjs-wallet/blob/567f32935f943e4c7414a3ce2c5be4410f80f846/src/index.js#L259)...

We have identified the cause of this issue and are working to find and ship a fix. We asses that a recent change we made to our JavaScript environment for...

I just want to chime in to thank @kdenhartog for their excellent work here and that we will follow up on [the PR to the MetaMask extension](https://github.com/MetaMask/metamask-extension/pull/15736) to get it...

Reproduced in Firefox but not Chrome on https://docs.metamask.io with the following `npx vuepress info`: ``` Environment Info: System: OS: macOS 10.15.6 CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz...

As of today's date, even Node 16 is EOL. Is there any appetite for dropping all Node versions

This is likely to be fixed by #4163 and related work.

This has actually been completed since we added `wallet_revokePermissions` in #1889.

This feature would be problematic from a localization perspective, but is perhaps something we could consider if we ever have programmatic (i.e. LLM-based) translations in the wallet.

@MetaMask/snaps-devs @MetaMask/mmi tagging you guys to confirm that your RPC methods continue to work as expected.