Erik Marks

Results 79 issues of Erik Marks

Removes the 3box sync feature and deletes the `ThreeBoxController`. Adds a migration to ensure that the `ThreeBoxController` is removed from persisted state. This shaves 600kb or 3.2% from our bundle...

DO-NOT-MERGE
MV3
PR - P1

Permissions of type `endowment` currently do not support caveats at all; the `allowedCaveats` of their specification objects must be `null`. This is because we didn't need caveats for the first...

enhancement
PermissionController

The [`SnapController.updateSnap()`](https://github.com/MetaMask/snaps-skunkworks/blob/5c1c0c92046bd6b016c518db773b5bb339a65861/packages/controllers/src/snaps/SnapController.ts#L1296) method performs some permission calculations that should occur in the `PermissionController`. In particular, it compares the permissions of an existing snap with that of a new version, revokes...

PermissionController
team-wallet-api-platform
team-wallet-framework

Replaces `[email protected]` with `@metamask/[email protected]`. ~This prevents some messages that appear to have been previously accepted from being signed, so this ought to be a breaking change.~

By iterating in the approval controller, I've bumped us up two major versions, and with #321, it will be a third. We should publish all controllers as individual packages, and...

enhancement
Epic

Node 12 is reaching EOL at the end of this month (April 2022). This PR bumps the minimum Node version for this repository and its package to 14. Since this...

`revokePermissions`, `revokeAllPermissions`, and related methods / actions of the `PermissionController` throw if the user is trying to revoke a permission that does not exist (which is either because a particular...

PermissionController
team-wallet-api-platform
team-wallet-framework

We should add a `require` parameter to permissions requests to allow domains to require specific permissions. These permissions cannot be deselected in the UI, and the entire request will fail...

PermissionController

We should validate the `factory` and `validator` properties of permission specifications in `ValidPermissionSpecification`, just as we do with the restricted method.

PermissionController
team-wallet-api-platform
team-wallet-framework

Adds the `noUncheckedIndexedAccess` TypeScript compiler flag to the repo-wide package `tsconfig.json`. Ref: https://github.com/MetaMask/metamask-module-template/pull/84 The following controllers must be updated to resolve issues with this rule: - [x] AddressBookController (8914b53) -...