Jack Lloyd

Results 182 comments of Jack Lloyd

Interesting! Thanks for bringing up this issue. I am wondering how other implementations perform this comparison. (CC @guidovranken - this might be an interesting test for CryptoFuzz. Not sure if...

Thanks for reporting. The Clang/GCC warnings are probably all fixable. IIRC the MSVC warnings are unavoidable for this codebase.

`C4267` might also be fixable. Can you post the warnings you are seeing? I cannot reproduce in CI, probably because our Windows CI is x86-64 only now.

Something like the information in this table https://botan.randombit.net/handbook/api_ref/pkcs11.html#tested-supported-smartcards would be very useful.

I think instead of `.start_cons( Botan::ASN1_Tag::SET )` you want `start_cons(ASN1_Tag(0), ASN1_Tag(CONSTRUCTED))`. This will not be completely correct, because the encoder will treat it like a sequence rather than a set,...

> When examining the hexdump using that ASN.1 javascript decoder mentioned in my first post, the example wraps the certificates with A080 ... 0000 while your solution adds a preceeding...

@0xdefaced Any luck with this? If there is something we should change upstream it would be good to know soon as we are 1 week away from the feature freeze...

I don't have much experience with Cmake but this might be helpful: https://github.com/keepassxreboot/keepassxc/blob/develop/cmake/FindBotan2.cmake

@MiniMinstrel Yes please!