Jack Lloyd

Results 182 comments of Jack Lloyd

This is great! Being able to test documentation examples is a feature I really like about `rustdoc` and have missed in C++. Also agree with @reneme that this would be...

Can you explain more about the reasoning for the virtual modules? I would have thought of say `math/` is just a plain directory which happens to contain some more module...

I general fine with this approach. For `Serialized_RNG` we might still want a (deprecated) constructor that takes a raw pointer in addition to one consuming a `unique_ptr`, but the others...

A good goal to shoot for IMO is to remove all uses of explicit `new` (now that we have `make_unique` available) in the same way that (almost) all uses of...

I thought the PKCS11 RSA wrapper already implemented this blinding? So I wouldn't think there would be any need for such operations at the application level as well. Or am...

Thanks for the report. The check added in efa5004354 looks to be incorrect.

Thanks for looking into this. AppVeyor's serial execution really hurts CI times and as a result over time the number of Windows configurations being tested has been pruned.

@reneme Sounds good. Please split into 3 PRs as you outlined.

That well known composite, 2 :joy: Thanks

> Do you have a recent version of ISO 14888-3 at hand? I do not. This was reported to me by @rb-anssi who indicated that the tests in libecc were...