Warnings that have to be disabled when I include botan_all.h/botan_all.cpp on various platforms

[oviano]

#ifdef APPLE #if defined(clang) #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wshorten-64-to-32" #pragma clang diagnostic ignored "-Wcomma" #pragma clang diagnostic ignored "-Wdeprecated-volatile" #endif #elif defined(ANDROID) #if defined(GNUC) #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wdeprecated-volatile" #endif #elif defined(_WIN32) #if defined(_MSC_VER) #pragma warning(push) #pragma warning(disable:4250) #pragma warning(disable:4251) #pragma warning(disable:4267) #pragma warning(disable:4275) #endif #endif

This is what is needed to build without warnings on macOS, iOS, tvOS, Android, Win32 and UWP in case you wanted to fix these...

[randombit]

Thanks for reporting. The Clang/GCC warnings are probably all fixable. IIRC the MSVC warnings are unavoidable for this codebase.

[randombit]

C4267 might also be fixable. Can you post the warnings you are seeing? I cannot reproduce in CI, probably because our Windows CI is x86-64 only now.