Jack Lloyd

Results 182 comments of Jack Lloyd

The first problem is just a missing cast and easily remedied. I'm really not sure what to make of `__cpuidex` missing. This used to work (though it's been many years...

OK this is weird - Godbolt supports ICC and there this compiles fine?!? https://godbolt.org/z/Pfnh4roGf what is different?

I hadn't decided what to do about `__cpuidex` until just now. It still seems very strange that it works on godbolt but not for you. Can you try 4aa1a8b?

> ld: build/obj/lib/asn1_alg_id.o: file class ELFCLASS32 incompatible with ELFCLASS64 You are mixing 32-bit and 64-bit object files. You probably need to do a make clean and rebuild.

Change looks fine. CI failure is related - the include should just be `botan/certstor_flatefile.h`

Still some CI failures. Also can you add tests? These could be either in C++ in `test_ffi.cpp` or done by exposing these to the Python interfaces and then adding the...

No need to close this - the change is fine. But if you are not able to add tests that merging will have to wait until I have the time...

Yeah there should be some additional function (for all modes) which basically exposes an optimium chunk size, probably something like: - If update_granularity is >= 4096 (?), just return update_granularity...

Interesting. If I check with `helgrind` I do see a large number of errors running the tests but these seem to be reflecting problems in GCC (https://stackoverflow.com/questions/41926894/can-helgrind-valgrind-be-used-with-c11-futures) since if I...

Here is what LLVM is doing with their current threadpool https://github.com/llvm/llvm-project/blob/master/llvm/lib/Support/Parallel.cpp#L120 With a note that "This also prevents intermittent deadlocks on exit with the MinGW runtime."