ramin
ramin
@vgonkivs can you nudge this over the line with @ptdatta to try and get this to satisfy closing the issue?
i think simplest here is to remove https://github.com/celestiaorg/celestia-node/blob/main/libs/utils/address.go#L40 which resolves the IP a single time on start, instead letting clients use the domain as passed in, and relying on the...
@jcstein this wont quite be solved by #3196, this is issue is regarding telemetry of metrics we'd instrument in the code and which node operators could optionally collect and visualize...
@ATREAY i can help with getting some unit tests in place so we can get this merged
@ATREAY i created some tests and refactored code here https://github.com/celestiaorg/celestia-node/commit/a7c7b16947e3c425ca15ea7dc09f992d6e45863c have a look, if you like and agree i can push the changes to this branch and we can see...
@Wondertan check this with some expanded tests, if you like we can replace this PR with it and get over the line: https://github.com/ATREAY/celestia-node/pull/1
replaced by https://github.com/celestiaorg/celestia-node/pull/3379
should be taken care of with shwap
> There is some wisdom behind the metaphor in [ca67fef](https://github.com/celestiaorg/celestia-node/commit/ca67fef50f89af5cbbc1b4ebfebc40f733ddae92), but I am not getting it @Wondertan ah, I put it back how it was, so no unnecessary change :-)
current warnings ``` header/header.go:36:21: fieldalignment: struct with 360 pointer bytes could be 344 (govet) type ExtendedHeader struct { ^ header/header.go:241:23: fieldalignment: struct with 56 pointer bytes could be 40 (govet)...