celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

das: Better metric for showing sampled range now that SamplingWindow is enabled

Open renaynay opened this issue 1 year ago • 4 comments

Right now, sampled chain head refers to the tip of the sampled chain which, while accurate, does not reflect that the light node may not have sampled everything before the SamplingWindow.

There should be some sort of metric that reflects where the light node began sampling potentially - or some way to know whether a light node has actually triggered a sampling job over block at height N.

Needs to be fleshed out a bit more.

(from discussions with @jcstein)

renaynay avatar Feb 22 '24 12:02 renaynay

I think #3196 should accomplish part of this, but may be wrong. cc @ramin

jcstein avatar Feb 26 '24 14:02 jcstein

@jcstein this wont quite be solved by #3196, this is issue is regarding telemetry of metrics we'd instrument in the code and which node operators could optionally collect and visualize to show metrics about the operation of a running node

ramin avatar Feb 27 '24 14:02 ramin

Now that https://github.com/celestiaorg/celestia-node/issues/3194 is resolved, this one needs to be as well.

renaynay avatar May 15 '24 13:05 renaynay

It should instead be a metric on the pruner. DASer is unaware of where or whether the latest pruned height is. In fact, it already exists as prnr_last_pruned (the pruner's highest pruned height). Therefore, the range of stored samples can be easily determined between the DASer head and this metric.

walldiss avatar May 15 '24 13:05 walldiss

@walldiss we have metrics on pruner (prune head) so does this resolve the issue here?

renaynay avatar Dec 02 '24 17:12 renaynay

Current metrics seems sufficient. If not, new issue is needed

walldiss avatar Jun 23 '25 18:06 walldiss