rails

rails copied to clipboard

Syntax errors are not presented correctly in ERB templates

1

Another ERB regression. Here's the template: ``` Posts ``` Here's the exception screen: 

dhh

Exceptions raised from templates should show template code not compiled methods

6

Seems like we've regressed on exceptions raised from within ERB templates. They're showing the backtrace of the compiled method instead of the underlying template. That's not very helpful. ![CleanShot 2024-02-14...

dhh

Use ruby file: ".ruby-version" when possible

5

Bundler has a nice new feature to get the ruby version from .ruby-version. Would be nice to take advantage of that when possible. So the default Gemfile should generate `ruby...

dhh

Run tests with `--profile` on CI

4

~~Debugging why a CI job get stuck is particularly painful as the output doesn't contain any information whatsoever.~~ ~~By enabling `--verbose` we ensure the last line of the CI job...

casperisfine

after_commit callbacks order is not consistent with after_save for autosaved records

2

### Steps to reproduce ```ruby # frozen_string_literal: true require "bundler/inline" gemfile(true) do source "https://rubygems.org" git_source(:github) { |repo| "https://github.com/#{repo}.git" } gem "rails", github: "rails/rails", branch: "main" gem "sqlite3" end require "active_record"...

4ndv

Path traversal in AcitveStorage, and lead RCE (Need secret_key_base)

1

From https://hackerone.com/reports/2334455 (Treated as Informative) --- The danger of deserialization has been reduced in Rails 7.1 by increasing the number of settings that do not use Marshal in MessageVerifier. However,...

ooooooo-q

Fix override existing join types in the query in the `where.associated` method

4

**Motivation / Background** Currently, the `where.associated` method in Rails only allows filtering associated records with an `inner join`, which can potentially override existing join types in the query. The fix...

saleh-alhaddad

ActiveStorage::FileNotFoundError due to upload after commit

17

We were getting `ActiveStorage::FileNotFoundError`s spuriously and are fairly confident that this is a race condition in the way ActiveStorage handles uploads and attachment. ### Steps to reproduce In the [rails...

sbungartz

Let ActiveStorage::Blob#open return a tempfile for manual unlinking

1

### Motivation / Background Wrapping code in a block is not always (easily) possible, this way it behaves like stdlib Tempfile that can be unlinked manually in addition to the...

bdewater

### Motivation / Background This Pull Request has been created because there are typos and variables are incorrectly named in #50914 . ### Detail This Pull Request changes: fix typo...

Yegorov