r0man

Results 138 comments of r0man

@cddr @creese Can we merge this? Or is there anything I can do to move this forward?

@cddr alright, thanks for the update

Hi @cddr, I just added the signoff message to my commit.

@zcaudate Thanks for the PR! However, I'm not sure to open up this extension point in the public API (yet). I would like to wait until React 16 is released,...

Hi @dum3ng, this has been asked a couple of times before. I'm not keen on extending the Sablono/Hiccup language with something like this at the moment, since it adds a...

Hi @augustl , I didn't add this yet, because of server side rendering. How would that work? The only solution I had in mind so far is emitting a blank...

@FreekPaans Nothing, I think you found a bug in sablono. :)

I guess the problem is in `wrap-form-element` over here: https://github.com/r0man/sablono/blob/master/src/sablono/interpreter.cljc#L29 I don't have time to look into this at the moment, so if you want to look into this, go...

@FreekPaans Looks like the node dependencies are not installed. Run `lein deps` once before running the tests. Not sure why `lein doo` doesn't fetch them. I would have expected that....

@FreekPaans Yes, this is a bit tricky. I think having an `on-change` handler that is not updating the value of the component, and the way we work around an IE...