jackdaw icon indicating copy to clipboard operation
jackdaw copied to clipboard

Add error handling to the EDN deserializer

Open r0man opened this issue 6 years ago • 6 comments

This is what I had in mind for issue #32.

r0man avatar Jan 10 '19 21:01 r0man

LGTM

cddr avatar Jan 17 '19 17:01 cddr

@cddr @creese Can we merge this? Or is there anything I can do to move this forward?

r0man avatar Apr 14 '19 13:04 r0man

Hi @r0man,

Apologies for the delay. We had to get the contributor guidelines/agreement in place before we can accept contributions from outside FC. Hopefully #122 does that so once that is merged I think we can get it in.

cddr avatar Apr 14 '19 13:04 cddr

@cddr alright, thanks for the update

r0man avatar Apr 14 '19 13:04 r0man

Hey @r0man,

Apologies once again for the delay but the contributor guidelines are now all in place and @sbrauer has helpfully already submitted a PR with the correct sign-off declaration.

https://github.com/FundingCircle/jackdaw/pull/143/commits

If you'd like to add the sign-off line to your commit in this PR then I'd be happy to merge it.

cddr avatar Jun 16 '19 10:06 cddr

Hi @cddr, I just added the signoff message to my commit.

r0man avatar Jun 17 '19 16:06 r0man