r0man

Results 138 comments of r0man

Hi Daniel, I'm in Sri Lanka at the moment and AFK for the next 4 weeks. I can take a look at this when I am back. Sorry, Roman. On...

I think the ideal solution would be to enhance the `get`, `post`, etc, functions to use the default client if the first argument is a string/url, and also accept a...

PR with tests welcome ...

Hi Murphy, I think the best way would be to make this configurable as a parameter to wrap-json-response and then build your own client with the stuff you need. I...

Sorry, I somehow missed this. What exactly do you have in mind? What should be more reusable? Did you get anywhere with you node version?

Not sure, but maybe this one? https://github.com/r0man/cljs-http/blob/master/src/cljs_http/util.cljs#L18

Hi Quantisan, the wrap-url middleware parses the URL into a Clojure map that is compatible with the Ring SPEC. If possible I would like to keep it that way and...

Hi @xsc, yes, removing the dynamically created fields from the record would address my concerns. :) Thanks, Roman.

Hi @czan, thanks for your suggestion. I keep them in mind going further. About the tricky change you pointed out. Maybe we could keep both the string and the (possibly...