Nate Lampton

Results 508 comments of Nate Lampton

Merged https://github.com/backdrop/backdrop/pull/4268 into 1.x and 1.23.x. Thanks @indigoxela and @klonos!

@Wylbur, thanks for updating those services! I added you to the backdrop-ops Pantheon team.

I'd like to advocate for this (hopefully very simple) feature for 1.24.0.

Initial PR for review: https://github.com/backdrop/backdrop/pull/4271 In particular, reviewing the default role descriptions assigned to anonymous, authenticated, and administrator would be helpful. Here's what I have in the PR: * anonymous:...

Thanks @bugfolder for this audit! Role Help's descriptions on the fields are a little confusing to me, since it says both fields are shown when editing a user's profile. Which...

I updated my PR at https://github.com/backdrop/backdrop/pull/4271 * Fixed PHP notices * Added test coverage * Split the single `description` into `admin_description` (Admin description) and `description` (Help text). Which matches terminology...

Discussed in dev meeting: We need to accomodate for non-upgraded Drupal 7 role names like 0 and 1 instead of anonymous and authenticated.

PR updated to account for numeric role IDs "1" (anonymous) and "2" (authenticated) if present in the `role_help` database table. I think all remaining PHPCS warnings are unrelated to this...

> I don't see descriptions for the roles. Wasn't that part of the intended behavior? The current implementation only adds admin-descriptions, not descriptions on the user account form. Only users...

Here are the descriptions I came up with: * Authenticated: Automatically assigned role to all accounts. * Editor: Permission to create and edit content. * Administrator: All permissions, including the...