Yanming Zhou
Yanming Zhou
If the entity has no cascades and events, then bulk delete should be used instead of fetching all and delete one by one.
> Removing the primary key isn't going to work, as Keyset scrolling must enforce uniqueness. Just accepting `Sort` isn't sufficient. What we could do is verify whether a unique property...
I mean it is the responsibility of developer to make sure keys combination unique if the document emphasize that.
Test improved to cover such cases: 1. unsorted (implicit sorted by id `asc`) 2. explicit sorted by id `asc` and `desc` 3. explicit sorted by seqNo `asc` and `desc` 4....
> Please, let's keep pull requests focused instead of mixing concerns within a single pull request. Sorry to disturb you, those changes are related and necessary to make the test...
`KeysetScrollIntegrationTests` is extracted to https://github.com/spring-projects/spring-data-jpa/pull/3030 after https://github.com/spring-projects/spring-data-jpa/issues/2999 resolved.
A viable proposal is adding a boolean property (eg. `keysetQualified`) to `Sort`, let developer hint that based on unique columns.
We could introduce a global property indicate that sort is unique ensured by developer.
Commit updated, I introduce method `JpaEntityInformation.isKeysetQualified()` and default implementation is check whether unique property present, then skip include id in keyset, please take a look @mp911de
> For the sake of documentation, I think these are related: > > * [Introduce withParentOnly for @Observed micrometer#3843](https://github.com/micrometer-metrics/micrometer/pull/3843) > * [Provide a simple way to make decisions based on...