Pavel Valena comments

Results 188 comments of


                                            Pavel Valena

Warning 'grep: warning: stray \ before x' in get_maj_min on aarch64

And I can confirm the proposed fix works: ``` $ bash -c "set -x; t='/dev/disk/by-partlabel/EFI\x20System\x20Partition'; : "$t"; : \"\${t//\\/\\\\}\"" + t='/dev/disk/by-partlabel/EFI\x20System\x20Partition' + : /dev/disk/by-partlabel/EFIx20Systemx20Partition + : '/dev/disk/by-partlabel/EFI\x20System\x20Partition' ```

feat(plymouth): install plymouth files via dracut-install

Other than that it LGTM, but I have not tested this in Fedora. Have you tried it on some OS?

Implement aliases for common actions

Also please take a look at my useful tmt commands I've noted: https://gist.github.com/pvalena/b4a94178c13e861fa8520c84aa8319b8

Implement aliases for common actions

> I think just aliases are not way to go, because they would be hard to document and create useful --help for them. I think some tmt subcommands with at...

Implement aliases for common actions

I completely agree. Integration of those with tmt is a key for further tmt adoption.

Implement aliases for common actions

It's something different, kind-of implements some things... To clarify: `try` shares one machine (same root ID?), right? If I run multiple IDs (f.e. per-repository or project) I'd always have to...

feat(create-missing-root): Introduce create-missing-root module

LGTM. Although I have not tested it yet. Will give it a try on Fedora and let you know the results.

Add build and push image to quay.io/fedora/ruby-33 repository

What about the test suite failures?

Add build and push image to quay.io/fedora/ruby-33 repository

``` Installing sass-rails 6.0.0 Gem::Ext::BuildError: ERROR: Failed to build gem native extension. current directory: /opt/app-root/src/bundle/ruby/3.3.0/gems/sqlite3-1.4.4/ext/sqlite3 ```

feat(fips): include openssl's fips.so and openssl.cnf

I'm unsure how this affects another distros.