Pavel Valena comments

Results 188 comments of


                                            Pavel Valena

project governance

Can you add me to PR approvers? I will reserve some time to help review PRs each week.

Fix test suite for Rails 7

LGTM.

Allow test selection using a shell script

Is this a generic case, or a special one?

Support dynamic plugins support for the test framework

> Would be nice, to have it as separate check plugins for shell and beakerlib frameworks, thats true, than have it hardcoded. I think we could make it really simple...

fix(fcoe-uefi): exit early on empty vlan

I have tested the snippet, but I'm unable to test in dracut, as I lack the HW / setup.

fix(fcoe-uefi): exit early on empty vlan

> @pvalena, could you update the PR as indicated above? Will do. Not sure why I didn't cover it in the `case`...

fix(fcoe-uefi): exit early on empty vlan

@mwilck PTAL.

fix(fcoe-uefi): exit early on empty vlan

Sure thing... this should have identical behaviour.

fix(fcoe-uefi): exit early on empty vlan

Just `shfmt` whitespace change... fixed.

fix(fcoe-uefi): exit early on empty vlan

Sure, let's enhance it further. Sorry about the forgotten commit message :) will clear things up.