s2i-ruby-container icon indicating copy to clipboard operation
s2i-ruby-container copied to clipboard

Add build and push image to quay.io/fedora/ruby-33 repository

Open phracek opened this issue 1 year ago • 8 comments

This pull request adds GitHub action for building and pushing each Fedora ruby container into quay.io/fedora/ruby-{version} registry

phracek avatar Jun 19 '24 12:06 phracek

[test-all]

phracek avatar Jun 19 '24 12:06 phracek

@jackorp PTAL. Let's build and push Fedora ruby-containers into quay.io/fedora/ruby-{version} registries.

phracek avatar Jun 19 '24 12:06 phracek

My eyes don't see anything else that would seem out of place or weird, so rest is LGTM.

jackorp avatar Jun 19 '24 12:06 jackorp

What about the test suite failures?

pvalena avatar Jun 19 '24 13:06 pvalena

Installing sass-rails 6.0.0
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/opt/app-root/src/bundle/ruby/3.3.0/gems/sqlite3-1.4.4/ext/sqlite3

pvalena avatar Jun 19 '24 13:06 pvalena

What about the test suite failures?

Fedora Ruby 3.3 is failing on compiling the gems for some time now. It might be that an update of some app's gems are needed due to some changes or updates in compiler on Fedora.

I haven't had time to properly investigate it yet.

jackorp avatar Jun 19 '24 13:06 jackorp

There was a bit outage of OpenShift cluster. re-running tests and let's see.

phracek avatar Jun 20 '24 08:06 phracek

Ruby-3.3 tests on Fedora are reported here: https://github.com/sclorg/s2i-ruby-container/issues/550

phracek avatar Jun 25 '24 08:06 phracek

@phracek https://github.com/sclorg/rails-ex/pull/173 to fix the Fedora Ruby 3.3 was merged, please re-run the tests.

jackorp avatar Jul 10 '24 09:07 jackorp

[test]

phracek avatar Jul 17 '24 07:07 phracek

Looks like Fedora Ruby 3.3 passed, but there is still failing gem build (Search for line An error occurred while installing nio4r (2.5.7), and Bundler cannot continue., which is at the end of failed installation), but it doesn't lead to failed CI or a failed test, so I am quite confused what source is being used there (it is not the rails-ex app).

JFTR, it seems like the same class of issue as sqlite3 so some app probably needs dependency adjustment, I just am not sure which one. Could we add a log line into tests that would say what is URL (with branch ideally) of a cloned app or if it is some "app" local to this repo, which source it is actually using?

Also the question is how come the test passes when the build of the container for test seems to fail?

jackorp avatar Jul 17 '24 11:07 jackorp

Looks like Fedora Ruby 3.3 passed, but there is still failing gem build (Search for line An error occurred while installing nio4r (2.5.7), and Bundler cannot continue., which is at the end of failed installation), but it doesn't lead to failed CI or a failed test, so I am quite confused what source is being used there (it is not the rails-ex app).

JFTR, it seems like the same class of issue as sqlite3 so some app probably needs dependency adjustment, I just am not sure which one. Could we add a log line into tests that would say what is URL (with branch ideally) of a cloned app or if it is some "app" local to this repo, which source it is actually using?

Also the question is how come the test passes when the build of the container for test seems to fail?

I will look at it. It seems like it is not related to OpenShift 4. I prefer to file an issue with the error and fix it later on, so we do not block this issue. WDYT?

phracek avatar Jul 17 '24 11:07 phracek

I prefer to file an issue with the error and fix it later on, so we do not block this issue. WDYT?

Sounds good to me.

jackorp avatar Jul 17 '24 11:07 jackorp

@jackorp I checked the logs for Fedora 3.3 and rails-ex is not used. It is used only in test case 'test_from_dockerfile'. I guess, the failure should be caused by different an issue. The test case that failed is 'test_npm_functionality'

phracek avatar Jul 17 '24 11:07 phracek

I prefer to file an issue with the error and fix it later on,

I have created #554

jackorp avatar Jul 17 '24 11:07 jackorp

I guess, this can be merged, right?

phracek avatar Jul 17 '24 12:07 phracek

Yes, I'd say we can go ahead with this.

jackorp avatar Jul 17 '24 12:07 jackorp