jli

Results 105 comments of jli
trafficstars

@trishume actually expressions are parsed at parse-time since https://github.com/Shopify/liquid/pull/391 and https://github.com/Shopify/liquid/pull/443 :D Definitely still some possible edge-cases though. The way I want to validate this is to format, reparse, and...

@fw42 I agree about it being separate. However, since parsing is implemented in the tags, and formatting is tightly coupled to the parse output, I think it is correct given...

In that case, since the syntax is `for item in array limit:2 reversed`, it arguably makes sense to have the current behaviour.

:+1:, addresses the original issue and doesn't require verifying templates don't break.

So the syntax it supports is the first version in @fw42's earlier comment, not the second.

Could do this with static analysis – I need to get the harness set up for that again anyway (for the formatter and #569) so maybe that's the best course...

See the comment in the example: ```js conn.on('auth', function() { // You must wait until this event is fired before sending any commands, // otherwise those commands will fail. ```...

Okay, got it. Can you provide any more information? What game server are you using? If possible, a packet capture would be helpful to identify any issue. For example, using...

It looks like the server-side socket is timing out since there's not much traffic on the connection. Two things you could try: - Disconnect the connection on response, and reconnect...