jli

The API for this exists since 3a010f0f668d8de59fcba75b14e08a6a08ec68a0. However, trying to use it seems to throw validation errors due to internal barriers being set up wrong. #1591 I'm curious to hear...

:+1:

I'm fairly sure the Varnish 4 VMOD API is backwards incompatible with 3.

This is a really good point, thanks for opening the issue. Some options: - your suggestion of using `if` as a key existence operator in strict_variables mode - new filter...

cc @dylanahsmith @Thibaut IMO this is a bug, and fixing it would make adopting strict_variables possible in Shopify for new templates. Out of the options in https://github.com/Shopify/liquid/issues/1034#issuecomment-426011407 what do you...

`contains` will work for container types like hashes, but I don't think it will work for drops, which don't respond to `include?`. https://github.com/Shopify/liquid/blob/e83b1e415990894c9517f94a8c2020ff825da027/lib/liquid/condition.rb#L20-L27 Though modifying the implementation of `contains` to...

First, if you prepend codes such that the length is always the same, string sorting will work. This means, use `001` instead of `01`. If you can't do that, I...

The problem is that we separate the tokenizer and parser, which is necessary for the regex approach but not for the strict approach. I don't think we're at the state...

Indifferent as well, I don't mind this but I also think many cases should be accomplished with lists and CSS instead.

Code looks good in either case.