jli

Results 105 comments of jli
trafficstars

This is due to https://github.com/Shopify/liquid/pull/492/commits/9f7e6011109e0f979043f89542f5bcebea51e407. I'm fairly sure breaking `to_str` for drops was not intended. We could solve this by having the default `Liquid::Drop#to_s` implementation be something like: ```diff -...

Accepting a block is not yet a concept in Liquid. I'm not going to merge this yet though, because it's possible that could change.

For some reason Travis CI was disabled for this repo. I enabled it again, new commits should be built.

Checking just the first element for `[]` is a heuristic used by other filters already, and in Shopify seems to work fine while being much faster than checking in the...

The constant overhead is dominating in that benchmark with just 4 elements. With an order of magnitude or two more elements the result should be different. Removing ` !ary.first[property].nil?` is...

Implementation LGTM. I noted a method in https://github.com/simple-icons/simple-icons/issues/480#issuecomment-319189883 for your use-case that avoids an exponential, so until this is also needed by others (I've never seen it requested before) I'd...

Why does it make any sense to allow this?

Hmm, division is perhaps the most compelling reason why this would happen, can we handle that more directly by rounding if the number is an epsilon away from an integer?