Justin Li

Results 41 comments of Justin Li

I know there are big plans for Styling V2, but I just wanted to drop by and mention we're still using this patch. I updated ImGui to master in our...

To draw inspiration from the unix world, perhaps a good solution for this use case could be: - an `export` tag that pushes the specified variable up to the calling...

I believe `env.liquid` will be exported with the theme. It will also be stored in the DB along with other Liquid files used to render the page. There is no...

A thread local is appealing but a basic implementation would preclude Liquid's use within concurrent applications that don't use a thread-per-connection model. Some kind of per-render key would fix this,...

> I'm not sure I understand what this has to do with connections. It is just the render context we would be propagating. Since we are already doing that, I...

I vote to mark this #wontfix in the lax parser since I bet there are templates that will break if we do :crying_cat_face:.

We could totally implement parentheses with the new parsers, but it would probably break some templates that are using them regardless of whether they do anything or not. We even...

That would work, but it would also be really confusing going forward. I think if we do this at all we should work towards unifying syntax and formally specifying it.

In this case it's not simple at all and any patch we accept is going to take a long time and a lot of testing/validation on our end.

Opus and/or Vorbis streaming would be great, though any of the high compression codecs are well suited to very long content and I would be happy with any of them.