Johan Euphrosine

Results 573 comments of Johan Euphrosine

> That means that the environment installation cannot happen from the notebook until we are back alive. Does the installations needs to happen with the environment activated? Or would executing...

I believe the README might have errouenous value for `Broadcast` and `Listen` port. - `Broadcast port` should match the UDP port the virtual device is listening on `3311` - `Listen...

@fanwu8184 can you confirm how you use the data returned by firebase, I don't see `firebaseDataObj` being used in the command snippet you've pasted. If you need data associated to...

Nice, thanks for sharing!

Can you paste the output of `npm ls --depth`?

Yes but https://developers.google.com/assistant/smarthome/develop/process-intents seems to indicate that most response could return `errorCode`

As mentioned in https://github.com/actions-on-google/actions-on-google-java/issues/30#issuecomment-644234766, I think we should consider tying the lifecycle of the channel to `SmartHomeApp`. Should we split the fix to `CONTRIBUTING.md` in a separate pull request?

@2m just a related note that we are also considering removing this homegraph wrapper altogether in favor of having developer depends directly on the generated homegraph bindings: https://github.com/googleapis/google-api-java-client-services/tree/master/clients/google-api-services-homegraph/v1 I'd be...

one way to make the documentation testable/executable could be to use something like https://jupytext.readthedocs.io/en/latest/index.html to maintain page with commands and snippets as jupyter notebook.