Johan Euphrosine
Johan Euphrosine
@dassbrothers was asking for a few pointers: ### how to get the `Function` params name: - https://github.com/google/xls/blob/aa165490129cdb522c13d2369f9b8aabb32e2cbe/xls/ir/function_base.h#L84 - https://github.com/google/xls/blob/aa165490129cdb522c13d2369f9b8aabb32e2cbe/xls/ir/nodes.h#L724 ### how params are translated to z3 - https://github.com/google/xls/blob/aa165490129cdb522c13d2369f9b8aabb32e2cbe/xls/solvers/z3_ir_translator.cc#L644-L669 ### assert...
@hpretl for the `sky130.lyp` vs `sky130A.lyp` error I think this is related to https://github.com/RTimothyEdwards/open_pdks/issues/332#issuecomment-1632079484
As an additional keyword consideration, it seems that the Rust community is also discussing `if const`, see https://github.com/rust-lang/rfcs/issues/3582#issuecomment-2100460117
> I don't understand why CI is failing: Looks like this was fixed w/ rebasing? (underlying issues w/ `check-cpp-absolute-includes` has been fixed in https://github.com/google/xls/commit/62022c1fe8095e7d31c38f899949639dcf3e7013)
> I see both of the following, so I'm not sure what the consensus is I'd personnally be up for us to split the generated tests in a separate PR...
Marking this as draft until it's ready to review again.
For reference, rust's take on this is: https://doc.rust-lang.org/reference/items/enumerations.html#implicit-discriminants
@richmckeever: ping for review ? adding @cdleary too.
@meheff did you get a change to look at @mikex-oss comments?
this also need to be rebased.